Merge dev -> master #1474
Merged
Merge dev -> master #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the all-dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [go.sia.tech/core](https://github.com/SiaFoundation/core) | `0.4.2` | `0.4.3` | | [go.sia.tech/coreutils](https://github.com/SiaFoundation/coreutils) | `0.2.3` | `0.2.5` | | [golang.org/x/crypto](https://github.com/golang/crypto) | `0.25.0` | `0.26.0` | | [golang.org/x/sys](https://github.com/golang/sys) | `0.23.0` | `0.24.0` | | [golang.org/x/term](https://github.com/golang/term) | `0.22.0` | `0.23.0` | Updates `go.sia.tech/core` from 0.4.2 to 0.4.3 - [Commits](SiaFoundation/core@v0.4.2...v0.4.3) Updates `go.sia.tech/coreutils` from 0.2.3 to 0.2.5 - [Commits](SiaFoundation/coreutils@v0.2.3...v0.2.5) Updates `golang.org/x/crypto` from 0.25.0 to 0.26.0 - [Commits](golang/crypto@v0.25.0...v0.26.0) Updates `golang.org/x/sys` from 0.23.0 to 0.24.0 - [Commits](golang/sys@v0.23.0...v0.24.0) Updates `golang.org/x/term` from 0.22.0 to 0.23.0 - [Commits](golang/term@v0.22.0...v0.23.0) --- updated-dependencies: - dependency-name: go.sia.tech/core dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-dependencies - dependency-name: go.sia.tech/coreutils dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-dependencies - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Mostly refactoring except for 2 changes: 1. fetching revisions no longer tries to pay by EA, then by contract and then not at all. It will always fetch revisions without payment since it's only 1 hasting anyway. 2. renewals always fetch a temporary price table for renewing instead of checking for an existing one to completely rule out the annoying revision<->price table chicken and egg problem.
This PR adds default values for the `PricePinSettings`. The UI only needs a default for the `ForexEndpointURL` but I figured we might as well add a sane default for all values, except for the actual pins, for documentation purposes.
### Patch Changes - 9e6640a3: Fixed an issue where network averages shown on pinned field tips did not follow the currency display preference.
It seems like right now the cached contracts are not updated when a new contract is added. This fixes that. I noticed because the worker failed to refill ephemeral accounts in my open PR since the cached contracts were always 0 because the cache was initialized before the contracts had been formed.
This PR proposes a series of small changes in an attempt to fix (or improve) the drift we see in production. I have not been able to reproduce (meaningful) negative drift in a test locally and found debugging it on production quite challenging because you want to caveman debug both sides ideally. The following changes definitely improve things, but we'll need to keep following it up. - [x] plug leaks where we weren't withdrawing money from the EA even though we paid for things like PT updates - [x] pessimistically withdraw money from the account in `DownloadSector` (host only refunds storage revenue on failure) - [x] sync newly created accounts (avoids funding already funded accounts) - [x] reset drift in production (fresh start allows for better follow up) I considered syncing the account balance when we fund an account. I went back and fourth on that several times but eventually removed it because it more or less makes `requiresSync` obsolete. The benefit though would be that you are certain the account has 1SC in it after you fund it, while at the same time keeping track of drift. So drift would still build up, but at the very least you have an account with 1SC and you never run into unexpected insufficient balance errors...
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChrisSchinnerl
force-pushed
the
chris/v110
branch
from
6a07b6a
to
d615bdd
Compare
Refactoring the node setup it looks like I made `autopilot.Run` blocking. This prevents S3 setup from successfully completing. Fixes #1473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.