-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor worker to derive its own account for each host #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
2 times, most recently
from
August 21, 2024 09:09
a382ef2
to
45b2a76
Compare
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
from
August 21, 2024 14:14
9938cc9
to
bcd15cf
Compare
This PR moves contract formation to the bus and gets rid of routes that became redundant because of the move. I want to draw attention to the route I added which is `POST /contracts`, I originally had `POST /rhp/form` but I think now is a good time to reconsider having `rhp` in the route. There's really no need to expose that to someone using the API. Fixes #1456
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
from
August 22, 2024 08:59
429edf3
to
5857876
Compare
peterjan
reviewed
Aug 26, 2024
peterjan
reviewed
Aug 26, 2024
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
from
August 26, 2024 12:45
a2659e2
to
f6a04a7
Compare
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
from
August 26, 2024 12:50
f6a04a7
to
1111f8c
Compare
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
from
August 26, 2024 13:44
032f466
to
2a37f1a
Compare
peterjan
reviewed
Aug 26, 2024
ChrisSchinnerl
force-pushed
the
chris/accounts
branch
from
August 27, 2024 08:41
2a43c2d
to
c90c19a
Compare
peterjan
reviewed
Aug 28, 2024
peterjan
reviewed
Aug 28, 2024
peterjan
reviewed
Aug 28, 2024
peterjan
approved these changes
Aug 28, 2024
@alexfreska this PR requires updating the UI. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1462