Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of contract related helper types #1425

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Aug 9, 2024

This is a cleanup of our contract database types.

Also extends the api.ArchivedContract type with various missing fields which were previously not exposed at all and only persisted in the database. Such as the reason for an archival.

@ChrisSchinnerl ChrisSchinnerl self-assigned this Aug 9, 2024
Base automatically changed from chris/gorm-cleanup to dev August 12, 2024 11:09
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review August 12, 2024 11:09
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like TestRenameObjects is failing because of a locked table. Likely an NDF I guess. I've seen one test hanging too and blocking for > 30 minutes but only saw it once so far.

@ChrisSchinnerl ChrisSchinnerl merged commit 10aef61 into dev Aug 12, 2024
7 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/gorm-cleanup-2 branch August 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants