Cleanup bus.go
#1413
Merged
Cleanup bus.go
#1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small cleanup of
bus.gobecause that file was growing unwieldy. Mostly it cleans up the constructor, the shutdown method and moves the api handler code into a separate file, ensuring that when we have to reorganise bus initialisation and setup you have a better overview inbus.go. There's definitely more to do, we can move a lot of stuff intointernaland we have to move some things out ofinternal, I plan to follow up with those changes but figured to get this 2.5k lines out of the way first.