Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ContractPruneMetrics to raw SQL #1305

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Migrate ContractPruneMetrics to raw SQL #1305

merged 3 commits into from
Jun 17, 2024

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Jun 14, 2024 •
edited
Loading

I'll get rid of the dbContractPruneMetric type when I migrate PruneMetrics.

@peterjan peterjan self-assigned this Jun 14, 2024
ChrisSchinnerl
ChrisSchinnerl approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to just address the comments in the next PR to avoid running the whole CI again.

stores/sql/metrics.go Outdated Show resolved Hide resolved
stores/sql/metrics.go Outdated Show resolved Hide resolved
stores/sql/metrics.go Outdated Show resolved Hide resolved
@peterjan peterjan marked this pull request as ready for review June 14, 2024 13:16
@ChrisSchinnerl ChrisSchinnerl merged commit 9dbcfb0 into dev Jun 17, 2024
7 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the pj/contract-prune-metrics-sql branch June 17, 2024 08:23
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

Assignees

@peterjan peterjan

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjan @ChrisSchinnerl