Forgive failed refresh only when contract is in set #1280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on Arequipa that sometimes after a reboot 6 or so contracts are added to the set which before failed to refresh. That is a result of the refresh failures not being persisted.
That reminded me that we probably don't want to forgive a failed refresh if a contract wasn't in the set to begin with since it will only increase churn if it causes another contract to be pushed out of the set for the next 6 hours instead.