Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renterd config command #1202

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Fix renterd config command #1202

merged 8 commits into from
Apr 30, 2024

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Apr 26, 2024

This PR makes sure that when you run renterd config and select sqlite there's no mysql section in the renterd.yml file (and vice versa of course). I figured this was a good opportunity to make the sqlite database names configurable and refactor the bus config in a way that creating the database connections (and logger) are better placed I think, it was a bit scattered before. There's actually a bunch of small changes that overall clean things up.

Fixes #1201

@peterjan peterjan self-assigned this Apr 26, 2024
@peterjan peterjan marked this pull request as ready for review April 26, 2024 13:07
config/config.go Outdated Show resolved Hide resolved
stores/hostdb_test.go Show resolved Hide resolved
cmd/renterd/main.go Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl merged commit b15f1ae into dev Apr 30, 2024
7 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the pj/database-config-refactor branch April 30, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

renterd generates incorrect config file according to user input at config time
2 participants