Extend worker mocks #1000
Merged
Extend worker mocks #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/mock-bus
branch
from
2b626d9
to
8782d82
Compare
peterjan
force-pushed
the
pj/mock-bus
branch
from
8782d82
to
08f0084
Compare
peterjan
force-pushed
the
pj/mock-bus
branch
from
64a2fe6
to
15fcd00
Compare
peterjan
force-pushed
the
pj/mock-bus
branch
from
15fcd00
to
145b505
Compare
ChrisSchinnerl
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
testWorker, it's essentially an actual worker built on top of a mock of our bus. I want to keep the mocks in theworkerpackage for the time being, I tried finding a better place for it but moving it into a separate package makes it a lot more annoying because you have to expose everything and you can't easily manipulate the mocks. I had some ideas to splitmocks_test.goand/or create atestingpackage exposing these mocks but the file ended up being reasonably manageable (for now at least) with ~600 lines.