-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signatone support #158
Signatone support #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
===========================================
- Coverage 39.21% 17.77% -21.45%
===========================================
Files 72 73 +1
Lines 4786 4817 +31
===========================================
- Hits 1877 856 -1021
- Misses 2909 3961 +1052
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me apart from the whitespace changes and the infinite loop issue.
wait, why are there commits from 2 years ago being pushed with this PR? |
Good point, I think this is from the way I rebased. Has however no effect on todays status of the code. |
01c631b
to
f5c39c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This PR adds support for the signatone prober in paris.