Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Verilator compatibility 2 #149

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Improve Verilator compatibility 2 #149

merged 1 commit into from
Dec 20, 2020

Conversation

flooklab
Copy link
Contributor

In tests, e.g. https://github.com/SiLab-Bonn/basil/blob/master/tests/test_SimFifo8to32.py,
empty may not settle correctly with Verilator, so that tests will fail.
This is solved by adding reset for empty.

@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #149 (e517fca) into master (af5e949) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   31.92%   31.92%           
=======================================
  Files          72       72           
  Lines        4780     4780           
=======================================
  Hits         1526     1526           
  Misses       3254     3254           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5e949...e517fca. Read the comment docs.

@themperek themperek merged commit db9489c into SiLab-Bonn:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants