Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #36

Merged
merged 19 commits into from
Nov 2, 2024
Merged

Add files via upload #36

merged 19 commits into from
Nov 2, 2024

Conversation

denizturan179
Copy link
Contributor

SiN design rev0. DR fails due to modification of the rings from python file. Is it possible to override this DR error?

SiN design rev0
Copy link

Welcome, new contributor!

Thank you for uploading your design.

If you have not already checked it, please run the SiEPIC Functional Verification in KLayout, using the menu SiEPIC-Verification-Functional Layout Check (V).

You may continue making updates to your design, or even contributing additonal designs (using a separate file name), until the tape-out deadline.

@lukasc-ubc
Copy link
Member

Please run verification "v" in KLayout SiEPIC-Tools.

There are lots of critical errors, so no, your design cannot be accepted as is.

  • multiple top cells
  • waveguides not connected properly
image image

@denizturan179
Copy link
Contributor Author

Errors fixed on my side.

@denizturan179
Copy link
Contributor Author

Hi, I added three SiN MDM layouts. Please let me know if there are any issues that prevent merging.

@lukasc-ubc lukasc-ubc merged commit c1f24d5 into SiEPIC:main Nov 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants