Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed front UI of the weather website #55

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

PritamSarbajna
Copy link
Contributor

Related Issue

#23 Weather website UI improvement

Describe Changes

I have changed the front ui of the weather website, you can check below.

Checklist

  • ✅ My code follows the code style of this project.
  • 🚩 All new and existing tests passed.
  • 🌟 I have starred the repo
  • 👀 I have read the Contributing Guideline

What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Screenshots

Screenshot (251)

@utkarsh006
Copy link
Contributor

@PritamSarbajna What changes have you done? Kindly mention it here, so that we can proceed further.

@PritamSarbajna
Copy link
Contributor Author

PritamSarbajna commented Dec 10, 2022

@PritamSarbajna What changes have you done? Kindly mention it here, so that we can proceed further.

Hello @utkarsh006 I have changed the following :

  • Made changes index.html like adding classes and a few divs. But the base structure is still the same.
  • I have created a static folder in which my style.css file is.
  • From the basic html structure, I just added a dynamically changing bakground and a lot of modifications as you can see in the screenshot above.

@utkarsh006
Copy link
Contributor

LGTM ⭐
@Shweta2024 Do Merge the PR.

@Shweta2024
Copy link
Owner

@PritamSarbajna great work!
LGTM🎉

@Shweta2024 Shweta2024 merged commit 128a162 into Shweta2024:master Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants