Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use item.kind (if available) instead of source.kind to get preview #103

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

kamecha
Copy link
Contributor

@kamecha kamecha commented Feb 29, 2024

Before this commit, to get preview we get kind name from source's kind only.

So if I want to custom each items via other sources but still don't want to change the item's kind, I can't do that.

For example, the other sources is ddu-source-custom_params

From this commit, we can get kind name from source's kind or from item's kind. So we can custom each items via other sources.

@Shougo Shougo merged commit 0db9306 into Shougo:main Mar 1, 2024
2 checks passed
@Shougo
Copy link
Owner

Shougo commented Mar 1, 2024

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants