Version Packages #462
Merged
Version Packages #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![shopify-github-actions-access[bot]](https://avatars.githubusercontent.com/in/221189?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@shopify/eslint-plugin@47.0.1
Patch Changes
#461
b1b449cThanks @BPScott! - Add@typescript-eslint/no-unused-expressionsto typescript rulesetIn v46 in, we enabled
no-unused-expressionsin the core js config, then disabled it and replaced it with@babel/no-unused-expressionsin esnext config. In typescript files we turn offno-unused-expressionsbut left@babel/no-unused-expressionsenabled - which seems like an oversight given that@typescript-eslint/no-unused-expressionsexisted. In v47.0.0 we removed configuration of@babel/no-unused-expressionsentirely, which meant that there was no linting of unused-expressions. This change brings back unused expression linting to typescript files.