Use Record instead of index signatures

.changeset/kind-monkeys-refuse.md

@@ -0,0 +1,5 @@
+---
+'@shopify/eslint-plugin': major
+---
+
+Change the @typescript-eslint/consistent-indexed-object-style rule to use default error settings, aka Record over index signature

packages/eslint-plugin/lib/config/typescript.js

@@ -264,10 +264,7 @@ module.exports = {
         // Requires that private members are marked as readonly if they're never modified outside of the constructor
         '@typescript-eslint/prefer-readonly': 'off',
         // This rule enforces a consistent way to define records.
-        '@typescript-eslint/consistent-indexed-object-style': [
-          'error',
-          'index-signature',
-        ],
+        '@typescript-eslint/consistent-indexed-object-style': 'error',
         // Disallows unnecessary constraints on generic types
         '@typescript-eslint/no-unnecessary-type-constraint': 'error',
 

packages/images/optimize.d.ts

@@ -1 +1 @@
-export function svgOptions(): {[key: string]: unknown};
+export function svgOptions(): Record<string, unknown>;

packages/typescript-configs/definitions/styles.d.ts

@@ -1,9 +1,9 @@
 declare module '*.scss' {
-  const classNames: {[key: string]: string};
+  const classNames: Record<string, string>;
   export default classNames;
 }
 
 declare module '*.css' {
-  const classNames: {[key: string]: string};
+  const classNames: Record<string, string>;
   export default classNames;
 }