-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ecmaVersion to 'latest' in esnext.js in eslint-plugin to ensure it's esnext. #296
Conversation
CLA assigned. Please reruns.. |
@iamyoki Thanks for the contribution and apologies for the delay. Do you mind adding an entry in the corresponding |
@lucabezerra No problem. |
@iamyoki Actually I meant under the |
@lucabezerra Yeah, my mistake, fixed. |
@iamyoki I think you added it twice by mistake, heh :) |
@lucabezerra Hah, finally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest
isn't supported in our the parsers versions that we currently require.
Let's have use ecmaVersion: 2021
to get us onto the latest version in this PR
Then if you're feeling a brave, open new PRs for replacing babel-eslint
with @babel/eslint-parser
, and updating @typescript-eslint/parser
to the latest version in the v4 branch (we'll want to go to v5 at some point but perhaps we should do that as part of the plugin updates required to support eslint v8).
Description
This PR updates a simple config in esnext.js in eslint-plugin, it prevents some potential problems.
It updates
to
so to ensure it always be esnext latest version.
Here is the official docs mentioned: https://eslint.org/docs/user-guide/configuring/language-options#specifying-parser-options.
Also updates env
es6
toes2021
.Type of change
Checklist