[Eslint] jsx-ally | Removing jsx autocomplete valid rule #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, does what's advertised. |
yourpalsonja
approved these changes
Jun 21, 2021
alex-page
approved these changes
Jun 22, 2021
andrewmcgov
approved these changes
Jun 22, 2021
|
should we wait for #251 to be merged and then this PR can diisable the old and enable the new in one go? |
BPScott
reviewed
Jun 22, 2021
|
#251 is merged! |
PR number Fixing whitespace Update packages/eslint-plugin/CHANGELOG.md Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Add react-require-autocomplete lint rule
gcornhill
force-pushed
the
eslint-jsx-remove-autocomplete-valid
branch
from
a4ca61e to
ac8bb63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a rule coming soon to require autocomplete on all inputs. This means there will be a lot of
autocomplete="off/nope". Howevernopeis not valid, but due to longstanding chrome bugnopeis the random string that will actually turn it off for Chrome. See notes here.One the required rules go out, we will look to make our own valid rule like the above but allow
nope.Type of change
Checklist