Use Record instead of index signatures

Shopify · Dec 4, 2023 · 8720143 · 8720143
1 parent 19c8d94
commit 8720143
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.changeset/kind-monkeys-refuse.md b/.changeset/kind-monkeys-refuse.md
@@ -0,0 +1,5 @@
+---
+'@shopify/eslint-plugin': major
+---
+
+Change the @typescript-eslint/consistent-indexed-object-style rule to use default error settings, aka Record over index signature
diff --git a/packages/eslint-plugin/lib/config/typescript.js b/packages/eslint-plugin/lib/config/typescript.js
@@ -264,10 +264,7 @@ module.exports = {
         // Requires that private members are marked as readonly if they're never modified outside of the constructor
         '@typescript-eslint/prefer-readonly': 'off',
         // This rule enforces a consistent way to define records.
-        '@typescript-eslint/consistent-indexed-object-style': [
-          'error',
-          'index-signature',
-        ],
+        '@typescript-eslint/consistent-indexed-object-style': 'error',
         // Disallows unnecessary constraints on generic types
         '@typescript-eslint/no-unnecessary-type-constraint': 'error',