This repository has been archived by the owner on May 30, 2024. It is now read-only.
Auto-restart the LSP on .rubocop.yml config changes #167
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
approved these changes
Jul 25, 2022
Morriar
reviewed
Jul 25, 2022
src/client.ts
Outdated
| @@ -177,6 +177,7 @@ export default class Client { | |||
|
|
|||
| private registerAutoRestarts() { | |||
| this.createRestartWatcher("Gemfile.lock"); | |||
| this.createRestartWatcher(".rubocop.yml"); | |||
There was a problem hiding this comment.
Should we also restart if a config file changed (or was added/removed) in a sub-directory?
There was a problem hiding this comment.
Yes, indeed. I've added the **/ to the pattern.
Morriar
approved these changes
Jul 25, 2022
jayanth-kumar-morem
pushed a commit
to jayanth-kumar-morem/vscode-ruby-lsp
that referenced
this pull request
Apr 26, 2023
…-static-and-runtime-0.5.10125 Bump sorbet-static-and-runtime from 0.5.10101 to 0.5.10125
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the RuboCop configuration changes, then we have to restart the LSP to reload the diagnostics and formatting runners. Otherwise, we keep processing files using the old configuration.