Adding CLI rst command

[peter-ginchev]

No description provided.

[peter-ginchev]

@jpittis Could you please review this chunk of code, and submit, if relevant, I just wanted to add RST functionality, which was useful for me.

[miry]

Hi @peter-ginchev

Thank you for your contribution. I wonder if you think your changes are still relevant, after so long time?

[peter-ginchev]

Hi @peter-ginchev

Thank you for your contribution. I wonder if you think your changes are still relevant, after so long time?

Yes, At that moment we wanted to simulate RST and we did it successfully using this patch.
I see that currently, the code has changed, and the conflict is around the fix I need to change the created client fro "net.Listen" to "net.ListenTCP", because RST is thrown on a TCP connection, and the connection previously was just IP.

[miry]

@peter-ginchev I checked the code and find misleading content.
Example the command description: reset a proxy. When I read it, I would assume it means to remove all settings for proxy (e.g disable all toxics). In same time the code drop connections to the proxy.

To remove doubts and expectations, can you update the description with usage case, it would help me to better comment on proposed code.

I am also checking similar proposals:

• Add a toxic to simulate "connection reset" #238
• RFC for creating TCP Reset toxic #247

[peter-ginchev]

@peter-ginchev I checked the code and find misleading content. Example the command description: reset a proxy. When I read it, I would assume it means to remove all settings for proxy (e.g disable all toxics). In same time the code drop connections to the proxy.

To remove doubts and expectations, can you update the description with usage case, it would help me to better comment on proposed code.

I am also checking similar proposals:

• Add a toxic to simulate "connection reset" #238
• RFC for creating TCP Reset toxic #247

Sorry for not being clear enough.
For me a proxy is a connection, so proxy reset, I've meant connection reset. Specifically, simulate TCP RST on the connection to the Proxy.

[miry]

Hi @peter-ginchev

I decided to use #247 as main solution to add Reset peer toxic.
It adds toxic with timeout to create a disturbance.

I released a new version https://github.com/Shopify/toxiproxy/releases/tag/v2.2.0
Let me know if it solves your use case as well.

[peter-ginchev]

Thanks, I don't have availability to check it right now. I'll close this PR, and will comment if in the future the released code doesn't suit me.