Skip to content

Commit

Permalink
Validate if tag signed before release
Browse files Browse the repository at this point in the history
Make sure there is always signed tag before release.
  • Loading branch information
miry committed Dec 23, 2021
1 parent 0fb6f5f commit bcfe69b
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 3 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,25 @@ jobs:
with:
fetch-depth: 0

-
name: GPG config
run: |
mkdir -p ~/.gnupg
cat << EOF >> ~/.gnupg/options
keyserver keys.openpgp.org
keyserver-options auto-key-retrieve
EOF
-
name: Verify tag signature
run: |
# NOTE: Solve the problem with Github action checkout https://github.com/actions/checkout/issues/290
git fetch --tags --force
version=${GITHUB_REF#refs/tags/*}
git show $version
git tag -v $version
-
name: Log into registry ${{ env.REGISTRY }}
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# [Unreleased]

* Verify git tag on release (#347, @miry)

# [2.3.0] - 2021-12-23

* Store all the executable `main` packages in `cmd` folder. (#335, @miry)
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -605,11 +605,9 @@ For example, `shopify_test_redis_master` or `shopify_development_mysql_1`.

### Release

1. Ensure this release has run internally for `Shopify/shopify` for at least a
day which is the best fuzzy test for robustness we have.
1. Update `CHANGELOG.md`
1. Change versions in `README.md`
1. Commit, Tag, and Push
1. Create a commit, signed tag, and push
1. [Bump version for Homebrew](https://github.com/Shopify/homebrew-shopify/blob/master/toxiproxy.rb#L9)

[blog]: https://shopifyengineering.myshopify.com/blogs/engineering/building-and-testing-resilient-ruby-on-rails-applications

0 comments on commit bcfe69b

Please sign in to comment.