Only try read resp if there was no error
#794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Sep 13, 2020
| @@ -127,7 +127,7 @@ func (client *HTTPClient) doWithRetry(req *http.Request, body interface{}) (*htt | |||
| return resp, fmt.Errorf("request timed out after %v retries, there may be an issue with your connection", client.maxRetry) | |||
| } | |||
| time.Sleep(time.Duration(attempt) * time.Second) | |||
| } else if resp.StatusCode == http.StatusTooManyRequests { | |||
| } else if err == nil && resp.StatusCode == http.StatusTooManyRequests { | |||
| after, _ := strconv.ParseFloat(resp.Header.Get("Retry-After"), 10) | |||
| client.limit.ResetAfter(time.Duration(after)) | |||
| } else if err != nil && strings.Contains(err.Error(), "no such host") { | |||
There was a problem hiding this comment.
@tanema it looks like if there's an error other than "no such host", then we ignore it? Would it be helpful to return an error here to aid future troubleshooting?
There was a problem hiding this comment.
It is not ignored, it will just be retried.
andyw8
force-pushed
the
andyw8/fix-handling-of-nil-resp
branch
from
8817950
to
0ccb7cf
Compare
|
I have taken care of this in #809 because the problem was a lot larger than this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #790
** NOT YET TESTED**
Warn Checklist