Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v1.1.1 release #772

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Prepare v1.1.1 release #772

merged 1 commit into from
Sep 1, 2020

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Sep 1, 2020

New release due to #767

Warn Checklist

  • This changes the interface and requires a Major/Minor version change.
  • I have 🎩'd these changes by using the commands I changed by hand.
  • I have added a dependancy to the project.
  • I have considered any potential impact on node-themekit

  • Update ThemeKitVersion in src/release/release.go and commit.
  • Make the release tool go install ./cmd/tkrelease
  • run git tag <version> && git push origin --tags && git push
  • Update the changelog.txt with the date of the version release
  • Release using tool
    • build all distributions make all
    • release tkrelease -k="AWS_ACCESS_KEY" -s="AWS_SECRET_KEY" vX.X.X
      • If releasing a different version than in src/release/version.go you can use -f to force, sometimes this is necessary for specific issue tags like v0.0.0-issue432 when trying to debug a issue.
      • Using beta/alpha tags on the version number will stop themekit from automatically updating to that version. It would have to be typed in specifically like theme update --version=v1.0.4-rc1
  • On GitHub create a new release for the tag and take note of any relevant changes.
    • Include a brief summary of all the changes
    • Include links to the Pull Requests that introduced these changes
  • Update the [documentation website]
    • run make serve_docs
    • update any changes to the API
    • commit changes
  • Update themekitversion in docs config docs/_config.yml to update the download links,
    then run make md5s to generate the checksums for the new files. Add these to the docs/_config.yml
    file as well.
  • Update Chocolatey package in the choco folder
    • Update the version in choco/themekit.nuspec
    • Update the version and checksums in choco/tools/chocolateyinstall.ps1
    • Run choco pack in a window VM
    • Log into chocolatey.org (use the themekit@shopify.com credentials) and submit an update for approval
  • Update themekit.rb formula for homebrew
    • run make sha to generate the SHA256 for the darwin build
    • update the link and sha in the homebrew formula
  • Notify the maintainer of the AUR themekit package https://aur.archlinux.org/packages/shopify-themekit-bin
    of an update so they can release a new version.

@andyw8 andyw8 force-pushed the andyw8/prepare-v1.1.1-release branch from f8ca919 to 0750541 Compare September 1, 2020 15:19
@andyw8 andyw8 force-pushed the andyw8/prepare-v1.1.1-release branch from 0750541 to 98db5ed Compare September 1, 2020 15:21
@andyw8 andyw8 marked this pull request as ready for review September 1, 2020 15:22
@andyw8 andyw8 requested a review from tanema September 1, 2020 15:23
@andyw8 andyw8 merged commit 4379183 into master Sep 1, 2020
@NickH-nz
Copy link

NickH-nz commented Sep 3, 2020

Thanks for all the work you do on ThemeKit, I'm really excited about the changes for using checksums on uploads and downloads.

Do you have any idea on the time frame for this release to get pushed to Chocolatey?

@andyw8
Copy link
Contributor Author

andyw8 commented Sep 3, 2020

Hi @NickH-nz, I ran into some Windows VM issues but I'm hoping to get it released very soon.

In the meantime, you should be able update to the newer version by running theme update.

@NickH-nz
Copy link

NickH-nz commented Sep 9, 2020

Thanks for the response.
I had tried theme update but ran into an error about the binary not being able access itself. Turns out it just needed to be run as admin, but the error message was different than what I'd expected for a permissions issue.

@andyw8
Copy link
Contributor Author

andyw8 commented Sep 9, 2020

Ok – if you run into this again, a note of the exact error would be helpful.

(The updated Chocolatey release is now available: https://chocolatey.org/packages/themekit )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants