Support 'password' in config, interchangeable with access_token #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbutcher
force-pushed
the
support_password_config_var_interchangeable_with_access_token
branch
from
d401c17
to
63848db
Compare
chrisbutcher
force-pushed
the
support_password_config_var_interchangeable_with_access_token
branch
from
63848db
to
d60ee56
Compare
| @@ -54,9 +57,12 @@ func (conf Configuration) Initialize() (Configuration, error) { | |||
|
|
|||
| if len(conf.Domain) == 0 { | |||
| return conf, fmt.Errorf("missing domain") | |||
| } else if !strings.HasSuffix(conf.Domain, "myshopify.com") { | |||
There was a problem hiding this comment.
Should we allow .com and .io?
|
One minor comment, otherwise 👍 |
|
Will 🚢 this this week, and create a new release at that time
|
chrisbutcher
added a commit
that referenced
this pull request
Mar 9, 2016
…rchangeable_with_access_token Support 'password' in config, interchangeable with access_token
chrisbutcher
deleted the
support_password_config_var_interchangeable_with_access_token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #104
passwordto Configure command workflow, which holds the same value sent to Shopify under the headerX-Shopify-Access-Token.config.yml, the termpasswordis used. It's also used within the Shopify Private Apps UI, as seen in the related issue above.passwordas the preferred flag name, andconfig.ymlkey. Eventually we should deprecate the termaccess_tokenthemekit (a warning is added when callingtheme configurewith-access_token=foo).Following my configuration refactor PR shipping, a lot of the duplication still visible in parts of this PR will be cleaned up. #135
Please review, @ilikeorangutans cc: @stevebosworth @cshold