Fix type of column_type parameter for handle_unknown_type method
#997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Jun 16, 2022
bagmangood
approved these changes
Jun 16, 2022
Morriar
reviewed
Jun 16, 2022
The passed value of `column_type` parameter is not necessarily always an `Object`. For example, `ActiveSupport::Types::Serialized` does not have `Object` as an ancestor, since it is defined as: ``` class Serialized < DelegateClass(ActiveModel::Type::Value) ``` which makes it subclass from `BasicObject`. We were using `Object` as the type for `column_type` parameter, but we really wanted to use `BasicObject` instead. I added a serialized column to a test case to see this fail before the change and pass after the change.
paracycle
force-pushed
the
uk-fix-method-parameter-type
branch
from
db9706e to
8bebf09
Compare
Morriar
approved these changes
Jun 16, 2022
paracycle
added a commit
that referenced
this pull request
Jul 1, 2022
Fix type of `column_type` parameter for `handle_unknown_type` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The passed value of
column_typeparameter is not necessarily always anObject. For example,ActiveSupport::Types::Serializeddoes not haveObjectas an ancestor, since it is defined as:which makes it subclass from
BasicObject.Thanks to @bagmangood for bringing this up.
Implementation
We were using
Objectas the type forcolumn_typeparameter, but we really wanted to useT.untypedinstead.Tests
I added a serialized column to a test case to see this fail before the change and pass after the change.