Refactor the interesting_ancestors_of method in the Mixins listener
#967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jun 6, 2022
lib/tapioca/gem/listeners/mixins.rb
Outdated
Comment on lines
74
to
75
| inherited_ancestors = Set.new.compare_by_identity | ||
| inherited_ancestors.merge(inherited_ancestors_of(constant)) |
There was a problem hiding this comment.
I think we can do all of this on a single line:
Suggested change
| inherited_ancestors = Set.new.compare_by_identity | |
| inherited_ancestors.merge(inherited_ancestors_of(constant)) | |
| inherited_ancestors = Set.new.compare_by_identity.merge(inherited_ancestors_of(constant)) |
lib/tapioca/gem/listeners/mixins.rb
Outdated
Comment on lines
94
to
95
| ancestors = Set.new.compare_by_identity | ||
| ancestors.merge(ancestors_of(constant)) |
There was a problem hiding this comment.
Same as above:
Suggested change
| ancestors = Set.new.compare_by_identity | |
| ancestors.merge(ancestors_of(constant)) | |
| ancestors = Set.new.compare_by_identity.merge(ancestors_of(constant)) |
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
egiurleo
force-pushed
the
interesting-ancestors-refactor
branch
from
5a26c12 to
8414af4
Compare
|
@paracycle beautiful! Implemented your one-liners. |
paracycle
changed the title
interesting_ancestors_of method in the Mixins listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use
Set#compare_by_identityto make the logic of theinteresting_ancestors_ofmethod easier to understand.Implementation
The old implementation worked as follows:
inherited_ancestorsas a new Set, and add all the object_ids of the modules ininherited_ancestors_of(constant)constant.ancestorsand reject any whose object_id is already ininherited_ancestors_idsThe new implementation is much more straightforward:
inherited_ancestorsas a new Set withcompare_by_identityinherited_ancestors_of(constant)to this setancestorsas a new Set withcompare_by_identityancestors_of(constant)to this setinherited_ancestorsfromancestorsand return the result as an arrayTests
Behavior should not change. Tests are still green.