Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Trigger ActiveSupport::TestCase DSL compiler on fixture changes #2163

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[LSP] Trigger ActiveSupport::TestCase DSL compiler on fixture changes #2163

wants to merge 15 commits into from
+64 −3

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jan 22, 2025 •
edited
Loading

Addresses https://github.com/Shopify/team-ruby-dx/issues/1305

TODO:

  • Point to ruby-lsp-rails once released (and update RBI)
  • Verify performance in Core
  • Consider extracting out some behaviour, we're doing a lot in changes.flat_map

@andyw8 andyw8 mentioned this pull request Jan 22, 2025
Closed
@andyw8 andyw8 added the enhancement New feature or request label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock