Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a Hash from GroupChain#size #2157

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Return a Hash from GroupChain#size #2157

merged 1 commit into from
Jan 20, 2025

Conversation

KaanOzkan
Copy link
Contributor

Motivation

#2153 (comment)

Implementation

Tests

@KaanOzkan KaanOzkan requested a review from a team as a code owner January 20, 2025 16:44
@KaanOzkan KaanOzkan requested a review from paracycle January 20, 2025 16:49
@KaanOzkan
Copy link
Contributor Author

@iMacTia does this look good?

paracycle
paracycle approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iMacTia
Copy link

iMacTia commented Jan 20, 2025

Yup, thank you 🙇 !

@KaanOzkan KaanOzkan merged commit e31e726 into main Jan 20, 2025
27 of 36 checks passed
@KaanOzkan KaanOzkan deleted the ko/groupchain-size branch January 20, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaanOzkan @iMacTia @paracycle