Use Ruby 3.4.1 locally and test against it on CI #2138
Merged
+56
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
changed the title
KaanOzkan
force-pushed
the
ko/ruby-3.4
branch
6 times, most recently
from
cb02b79 to
3365d41
Compare
`benchmark` gem will be removed as a default gem in Ruby 3.5.0 and requiring it without depending causes warnings
Ruby 3.4 contains a single quote instead of a backtick in the stack trace. We need to accept both since we still test with older Rubies
vinistock
approved these changes
Jan 7, 2025
KaanOzkan
commented
Jan 7, 2025
| @@ -11,7 +11,7 @@ def before_suite(suite) | |||
|
|
|||
| def record(test) | |||
| # Trim leading "test_dddd_" and replace it with "it " | |||
| test.name.gsub!(/^test_\d{4}_/, "it ") | |||
| test.name = test.name.gsub(/^test_\d{4}_/, "it ") | |||
There was a problem hiding this comment.
Strings will be frozen by default which means we can't modify the string test.name points to without a deprecation warning.
| @@ -5,6 +5,8 @@ | |||
|
|
|||
| module Tapioca | |||
| class ConfigTest < SpecWithProject | |||
| include Tapioca::Helpers::Test::Template | |||
There was a problem hiding this comment.
Needed for ruby_version
| tapioca/tests/dsl_spec/project/sorbet/tapioca/extensions/test\.rb:2:in\s['`]<top\s\(required\)>':\s | ||
| Raising\sfrom\stest\sextension\s\(RuntimeError\) | ||
| }x | ||
| assert_stderr_includes_pattern(result, err) |
There was a problem hiding this comment.
Only difference in these regexes is that now we can observe both a single quote or backtick based on Ruby version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2137
Implementation
Best reviewed commit by commit
Tests