Fix missing array signature for ActiveRecordRelation #create #1946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If passed an array, ActiveRecord's
#create
method will return an array of that models type. This is missing in the current implementation.Implementation
I've split the create methods so that the ones that are able to take arrays can now do so and return the type too.
Question for reviewers
Is there a preference on how to define constants for the single vs multi?
Tests