Show full result when failing to match output in tests #1112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to have a flaky test in
main
; the test failure only tells us that the output is empty, but it doesn't show anything about stderr or about the overall success.This PR introduces and uses two new assertions that might make it easier to debug such test failures:
assert_stdout_includes
assert_stderr_includes
If I manually setup a failure on that flaky test, this is what we get now: