Revert "Make ActiveRecord#find return value typed"

[paracycle]

Reverts #1089

The PR was merged, but the implementation is flawed and will not work in real applications.

Union types as return values don't work the way folks imagine them to work:

user = User.find(1)

user.name # Method name does not exist on T::Array[User] component of T.any(T::Array[User], User)

sorbet.run link

[vinistock]

I know this is not the point of this PR, but I wanted to call attention to the fact that Sorbet has started accepting overloaded method signatures (example).

Could we (in a follow up PR) change this generator to add two signatures? One that accepts and returns an array and another one that accepts a string or integer and returns a single record?

[paracycle]

I know this is not the point of this PR, but I wanted to call attention to the fact that Sorbet has started accepting overloaded method signatures (example).

Could we (in a follow up PR) change this generator to add two signatures? One that accepts and returns an array and another one that accepts a string or integer and returns a single record?

Sorbet has always accepted overloaded signatures in the payload since the beginning. But that is only guaranteed to work in # typed: __STDLIB_INTERNAL files which are supposed to be files in the payload.

I'd made a case for making that possible in all RBI files, which was met with a hesitantly warm reception, but there are edge cases to consider.

[andredriem]

I know this is not the point of this PR, but I wanted to call attention to the fact that Sorbet has started accepting overloaded method signatures (example).
Could we (in a follow up PR) change this generator to add two signatures? One that accepts and returns an array and another one that accepts a string or integer and returns a single record?

Sorbet has always accepted overloaded signatures in the payload since the beginning. But that is only guaranteed to work in # typed: __STDLIB_INTERNAL files which are supposed to be files in the payload.

I'd made a case for making that possible in all RBI files, which was met with a hesitantly warm reception, but there are edge cases to consider.

Those links are private now. Is there any news regarding the overloaded signatures?

[Morriar]

Is there any news regarding the overloaded signatures?

Overloads are now allowed in RBI files as an experimental feature: https://sorbet.org/docs/overloads.