Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to documentation of Protobuf compiler #1092

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

bmalinconico
Copy link
Contributor

Motivation

Reviewing how the compiler works and found a minor typo

Implementation

No details required

Tests

No details required

@bmalinconico bmalinconico requested a review from a team as a code owner August 1, 2022 13:44
Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you run bin/docs to update the generated doc files please?

@rafaelfranca rafaelfranca merged commit dca9d22 into Shopify:main Sep 8, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to production September 29, 2022 19:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants