Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActiveRecord#find return value typed #1089

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Make ActiveRecord#find return value typed #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2951ab4
Make ActiveRecord#find return value typed
gaborszakacs Jul 30, 2022
77bcc69
Empty commit to trigger new build
gaborszakacs Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tapioca/dsl/compilers/active_record_relations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ def create_common_methods(common_relation_methods_module)
parameters: [
create_rest_param("args", type: "T.untyped"),
],
return_type: "T.untyped"
return_type: "T.any(#{constant_name}, T::Array[#{constant_name}])"
)
when :find_by
create_common_method(
Expand Down
2 changes: 1 addition & 1 deletion spec/tapioca/dsl/compilers/active_record_relations_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def fifth; end
sig { returns(::Post) }
def fifth!; end

sig { params(args: T.untyped).returns(T.untyped) }
sig { params(args: T.untyped).returns(T.any(::Post, T::Array[::Post])) }
def find(*args); end

sig { params(args: T.untyped).returns(T.nilable(::Post)) }
Expand Down