Disable TracePoints when running the check-shims command #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profiling why this command was taking so much time, I found out that in the specific application I was working on 37% of the time was spent in the `TracePoint#method_id` method. Since we don't need this TracePoint enabled in this command, this patch disables it.
vinistock
approved these changes
Jul 28, 2022
paracycle
pushed a commit
that referenced
this pull request
Aug 22, 2022
Disable TracePoints when running the check-shims command
|
slightly unrelated question. @rafaelfranca The output of this tracing tool looks very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling why this command was taking so much time, I found out that in the specific application I was working on 37% of the time was spent in the
TracePoint#method_idmethod.Since we don't need this TracePoint enabled in this command, this patch disables it.
Profiling before
Profiling after
Total time went down from 3:50min to 1:20min