Add line numbers to the ConstantDefinition tracker #1029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Based on this suggestion.
We need the line numbers where constants were defined in order to add the original gem source locations for jump to definition. This PR saves this information in the
ConstantDefinition
tracker.Implementation
Added a
T::Struct
to keep track of path and line number, started populating it in the tracker and used the new method in the only occurrence offiles_for
.Tests
I contemplated adding a new test only for this tracker, but noticed that's not a pattern we're using in tests. Should I create a new one for this tracker?