Merge pull request #1089 from gaborszakacs/typed-active-record-find

Make ActiveRecord#find return value typed
Shopify · Aug 4, 2022 · 9e46b80 · 9e46b80
2 parents cfb03c6 + 77bcc69
commit 9e46b80
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/tapioca/dsl/compilers/active_record_relations.rb b/lib/tapioca/dsl/compilers/active_record_relations.rb
@@ -522,7 +522,7 @@ def create_common_methods(common_relation_methods_module)
                 parameters: [
                   create_rest_param("args", type: "T.untyped"),
                 ],
-                return_type: "T.untyped"
+                return_type: "T.any(#{constant_name}, T::Array[#{constant_name}])"
               )
             when :find_by
               create_common_method(

diff --git a/spec/tapioca/dsl/compilers/active_record_relations_spec.rb b/spec/tapioca/dsl/compilers/active_record_relations_spec.rb
@@ -93,7 +93,7 @@ def fifth; end
                     sig { returns(::Post) }
                     def fifth!; end
 
-                    sig { params(args: T.untyped).returns(T.untyped) }
+                    sig { params(args: T.untyped).returns(T.any(::Post, T::Array[::Post])) }
                     def find(*args); end
 
                     sig { params(args: T.untyped).returns(T.nilable(::Post)) }