Move parsing related classes to Spoom's top level #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
egiurleo
approved these changes
Jun 13, 2024
paracycle
approved these changes
Jun 13, 2024
amomchilov
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Just FYI: moving a Ruby file between different levels of nesting often loses the history, though it doesn't look too important in this case.
The simultaneous rename and large content diff (from all the indentation changes) don't get caught by git's move detection, so it just sees it as the deletion of the old file, and a creation of a new unrelated one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use those outside of the deadcode context, let's make them top level entities.
There is no functional change to this PR, only moving files/classes around.