Implement HTTP timeout/retry policies for GitHub/RubyGems/Slack clients #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
approved these changes
Nov 16, 2023
davidstosik
force-pushed
the
sto/net-retry
branch
from
8b8e831 to
91e4d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making sure that a single timeout will not invalidate the whole step in CI.
If timeouts keep happening, chances are the service is unavailable, so erroring is fine, but if a timeout is a fluke, we should at least retry.
As all HTTP clients in this gem were using the same settings, @gmcgibbon and I factorized the logic in a
HttpClientBuilderwhich we can also test.(WebMock takes
Net::HTTPcompletely out of the equation so it cannot test, for examplemax_retriesvalues.)