Handle better failures on TODO definition and archived Slack channels #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
rm-fail-on-errors
branch
from
2c6fdca to
d099f11
Compare
gmcgibbon
approved these changes
Jun 12, 2023
shioyama
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling smart todos again in our main application I found a bunch of invalid definitions which was causing the CLI to raise an exception without clear indication where the problem was being caused.
In this PR all the errors are now catch and present to the users in the end of the execution with the CLI retuning 1 as status. This will allow us to check for the todo signature on every commit.
I also found some TODOs pointing to channels that were archived, so we need to handle this new status.