forked from skypilot-org/skypilot
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for DWS GCE support #4
Merged
gurcangercek
merged 23 commits into
Shopify:dws-gce-support
from
skypilot-org:dws-gce-support
Jun 6, 2024
Merged
Fixes for DWS GCE support #4
gurcangercek
merged 23 commits into
Shopify:dws-gce-support
from
skypilot-org:dws-gce-support
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13461ad
to
78b3d2f
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the DWS GCE support.
Disabled: STOP and SPOT_INSTANCES for now, as MIG with DWS does not support stopping a machine.
TODOs:
Single node
sky launch -c test-mig --cloud gcp --cpus 2 --gpus t4 nvidia-smi
sky stop test-mig
(skip)sky down test-mig
sky autostop -i 0 test-mig
(skip)sky status -r test-mig
sky start -f test-mig
sky autostop -i 0 --down test-mig
sky status -r test-mig
Multiple nodes
sky launch -c test-mig-mn --num-nodes 4 --cloud gcp --cpus 2 --gpus t4 nvidia-smi
sky stop test-mig-mn
(skip)sky autostop -i 0 test-mig-mn
(skip)sky status -r test-mig-mn
sky start -f test-mig-mn
sky autostop -i 0 --down test-mig-mn
sky down test-mig-mn
Multiple spot nodes
sky launch --cloud gcp --gpus t4:4 --use-spot --num-nodes 4 nvidia-smi -c test-spot-mn
(skip)Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
pytest tests/test_smoke.py::test_gcp_mig
bash tests/backward_comaptibility_tests.sh