Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for DWS GCE support #4

Merged
merged 23 commits into from
Jun 6, 2024

Conversation

Michaelvll
Copy link

@Michaelvll Michaelvll commented Jun 5, 2024

This is to fix the DWS GCE support.

Disabled: STOP and SPOT_INSTANCES for now, as MIG with DWS does not support stopping a machine.

TODOs:

Single node

  • sky launch -c test-mig --cloud gcp --cpus 2 --gpus t4 nvidia-smi
  • sky stop test-mig (skip)
  • sky down test-mig
  • sky autostop -i 0 test-mig (skip)
  • sky status -r test-mig
  • sky start -f test-mig
  • sky autostop -i 0 --down test-mig
  • sky status -r test-mig

Multiple nodes

  • sky launch -c test-mig-mn --num-nodes 4 --cloud gcp --cpus 2 --gpus t4 nvidia-smi
  • sky stop test-mig-mn (skip)
  • sky autostop -i 0 test-mig-mn (skip)
  • sky status -r test-mig-mn
  • sky start -f test-mig-mn
  • sky autostop -i 0 --down test-mig-mn
  • sky down test-mig-mn

Multiple spot nodes

  • sky launch --cloud gcp --gpus t4:4 --use-spot --num-nodes 4 nvidia-smi -c test-spot-mn (skip)

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
    • pytest tests/test_smoke.py::test_gcp_mig
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll changed the title Fixes for DWS GCE support [WIP] Fixes for DWS GCE support Jun 5, 2024
@Michaelvll Michaelvll marked this pull request as ready for review June 6, 2024 04:41
@Michaelvll Michaelvll changed the title [WIP] Fixes for DWS GCE support Fixes for DWS GCE support Jun 6, 2024
@gurcangercek gurcangercek merged commit 0fb1809 into Shopify:dws-gce-support Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants