Fix bug where locale is not read from session #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpith
force-pushed
the
fix_2_letter_lang_code_issue
branch
from
1088c57 to
b0ec3bb
Compare
Merged
4 tasks
|
Thank you @nickpith - LGTM |
paulomarg
approved these changes
Jul 11, 2024
The changes in #1711 introduced a bug where single-page apps that don't include the locale param in subsequent requests were unable to properly set the locale that was persisted in the user session. Instead they would use the default locale. See https://github.com/Shopify/shopify_app/pull/1711/files#r1664570299 for background.
nickpith
force-pushed
the
fix_2_letter_lang_code_issue
branch
from
b0ec3bb to
07a695d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The changes in #1711 introduced a bug where single-page apps that don't include the locale param in subsequent requests were unable to properly set the locale that was persisted in the user session. Instead they would use the default locale.
See https://github.com/Shopify/shopify_app/pull/1711/files#r1664570299 for background.
Reviewer's guide to testing
Things to focus on
Nothing in particular since this is a very small change. A new test case was added to make sure it was accounted for.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary