Limit Rails version to ensure tests are running #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/limit-rails-to-ensure-tests-are-run
branch
from
a53f600 to
399faa1
Compare
klenotiw
approved these changes
Nov 1, 2022
fabriazza
pushed a commit
to fabriazza/shopify_app
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Andy Waite <andyw8@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Since the
Gemfile.lockwas updated to Rails 7 in #1518, the Ruby tests are not running, instead it is outputting therails newinfo, e.g. https://github.com/Shopify/shopify_app/actions/runs/3347688116/jobs/5545946051#step:7:113As a temporary fix until we find the underlying cause, let's limit the
Gemfileto < Rails 7. This should have no impact on the gem itself, since that doesn't involveGemfile.lock.Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary