Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Follow-up to #1247
An unintentional side-effect was introduced while cleaning up
.erb
templates. Moving app information from thebody
to a<script>
tag violates theunsafe-inline
Content Security Policy.Reviewer's guide to testing
shopify app create rails
Gemfile
inside the newly created appshopify_app
to point to this branch in your local environment, it should looks similar to this:gem 'shopify_app', path: '~/src/github.com/Shopify/shopify_app'
shopify app serve
, this will also output a ngrok urlhttps://1587ef2f72d5.ngrok.io/login?shop=sabotender-shop.myshopify.com
shop
entry for the store inside the app db (this will simulate one of the cases)config/intializers/shopify_app.rb
to trigger a redirect from within the shop framehttps://sabotender-shop.myshopify.com/admin/apps/test-app-1
Things to focus on
fullpage_redirect_to
,authenticate_at_top_level
, orenable_cookie_access
(Safari browser with strict 3rd party cookie policy)Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary