Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of unused generator flags #1000

Merged
merged 1 commit into from
May 29, 2020
Merged

Remove mentions of unused generator flags #1000

merged 1 commit into from
May 29, 2020

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 28, 2020 •
edited
Loading

In #776 we switched to reading the Shopify API key and secret from the environment, but a few references to the old approach were left over.

cc @tylerball

@andyw8 andyw8 requested a review from a team as a code owner May 28, 2020 18:56
tanema
tanema approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@tanema tanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyler no longer works for shopify and will not likely see or care about this issue lol

@andyw8 andyw8 merged commit 649780d into master May 29, 2020
@andyw8 andyw8 deleted the andyw8/remove-mentions-of-unused-flags branch May 29, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanema tanema tanema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @tanema