Clean up client side redirect tests

Shopify · Nov 24, 2022 · 55072d7 · 55072d7
1 parent 3f0b1d6
commit 55072d7
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/test/controllers/concerns/ensure_billing_test.rb b/test/controllers/concerns/ensure_billing_test.rb
@@ -59,9 +59,7 @@ def index
 
     get :index
 
-    assert_response :success
-    assert_match "Redirecting", response.body
-    assert_match(%r{https://totally-real-url}, response.body)
+    assert_client_side_redirection "https://totally-real-url"
 
     get :index, xhr: true
 
@@ -98,9 +96,7 @@ def index
 
     get :index
 
-    assert_response :success
-    assert_match "Redirecting", response.body
-    assert_match(%r{https://totally-real-url}, response.body)
+    assert_client_side_redirection "https://totally-real-url"
 
     get :index, xhr: true
 
@@ -166,9 +162,7 @@ def index
 
     get :index
 
-    assert_response :success
-    assert_match "Redirecting", response.body
-    assert_match(%r{https://totally-real-url}, response.body)
+    assert_client_side_redirection "https://totally-real-url"
 
     get :index, xhr: true
 
@@ -213,6 +207,12 @@ def index
 
   private
 
+  def assert_client_side_redirection(url)
+    assert_response :success
+    assert_match "Redirecting", response.body
+    assert_match(url, response.body)
+  end
+
   def stub_graphql_requests(*requests)
     requests.each do |request|
       stub_request(:post, "https://my-shop.myshopify.com/admin/api/#{@api_version}/graphql.json")