This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Fix bug that was causing duplicate keys in sessions #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
Apr 1, 2024
| (associatedUserObj.associated_user.id = Number(value)), | ||
| ]; | ||
| associatedUserObj.associated_user.id = Number(value); | ||
| return [key, undefined]; |
There was a problem hiding this comment.
Would we need to filter these undefined values? Having all of this in the switch inside the map does make it a bit hard to follow. I wonder if we should change this last map call to just directly access all of the fields? 🤔
There was a problem hiding this comment.
Yeah, this function is very confusing which is part of the reason I missed this at first.
I agree with a bit of a refactor.
…rtyArray, when returnUserData = true Refactor fromPropertyArray Remove console Cast to any
lizkenyon
force-pushed
the
liz/remove-duplicate-key-from-session
branch
from
2f6d120 to
96a0aab
Compare
We currently allow extra fields to be passed in
paulomarg
approved these changes
Apr 1, 2024
| Boolean(value); | ||
| break; | ||
| } | ||
| case 'emailVerified': | ||
| if (returnUserData) { | ||
| sessionData.onlineAccessInfo.associated_user.email_verified = | ||
| sessionData.onlineAccessInfo!.associated_user.email_verified = | ||
| Boolean(value); | ||
| break; | ||
| } |
There was a problem hiding this comment.
Looks good! One last question - can we replace setting the prototype of sessionData in line 137 with creating an actual Session instance? Not a blocker if we can't!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We were returning duplicate keys in the Session when using the new returnUserData flag, with the FromPropertyArray. I don't believe this should be causing any issues, because the key were also being added to the correct position in the object.
WHAT is this pull request doing?
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)