This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Return user session data behind flag #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some adapters currently pass in extra info by default We need a flag so that this is not a breaking change
lizkenyon
commented
Mar 26, 2024
| @@ -0,0 +1,2 @@ | |||
| --- | |||
There was a problem hiding this comment.
Let the changeset empty as this is just in addition to the other PR
lizkenyon
commented
Mar 26, 2024
| key, | ||
| (associatedUserObj.associated_user.id = Number(value)), | ||
| ]; | ||
| if (returnUserData) { |
There was a problem hiding this comment.
This switch statement got a more complicated with this change. Let me know if you are okay with this, or you would like this refactored into a (possibly) more readable if/else
There was a problem hiding this comment.
I think that's probably fine - this will eventually be removed so it's not the end of the world.
paulomarg
approved these changes
Mar 26, 2024
| key, | ||
| (associatedUserObj.associated_user.id = Number(value)), | ||
| ]; | ||
| if (returnUserData) { |
There was a problem hiding this comment.
I think that's probably fine - this will eventually be removed so it's not the end of the world.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1288
WHY are these changes introduced?
Some of the adapters can pass in additional information so we need to add a flag to the
fromPropertyArrayto keep the same functionality, and remove this as possible breaking change.WHAT is this pull request doing?
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfile manually)