Simplify constants' ::
prefix handling
#904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in #893 (comment), we could simplify visitor's
::
handling by moving itfully_qualify_name
.Implementation
I decided to handle prefix in
fully_qualify_name
instead ofIndex#initialize
becauseIndex#initialize
wouldn't be able to deal with the name pushed toIndexVisitor
's stack.Index.<<
is also not ideal as when it's calledentry.name
would already have the prefix.