Allow server to produce data telemetry #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
vscode
Graphite App
KaanOzkan
approved these changes
Feb 7, 2025
Morriar
approved these changes
Feb 7, 2025
Merge activity
|
### Motivation
Allow the server to produce data telemetry, in addition to error telemetry. This is useful for both the server and add-ons to track adoption of certain features or how they are used.
Here's an example of how it would be used.
```ruby
Notification.telemetry(type: "data", eventName: "tapioca.dsl", data: { type: "counter" })
```
### Implementation
Just added a branch for the data telemetry. Since the server and add-ons can send arbitrary data, I added runtime validation to prevent sending bad data to telemetry.
### Automated Tests
It's unfortunately not possible to test this because the client doesn't expose a way to fake an incoming notification. I did test it manually though.
graphite-app
bot
force-pushed
the
02-07-allow_server_to_produce_data_telemetry
branch
from
e67e32e to
583e72a
Compare
graphite-app
bot
deleted the
02-07-allow_server_to_produce_data_telemetry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow the server to produce data telemetry, in addition to error telemetry. This is useful for both the server and add-ons to track adoption of certain features or how they are used.
Here's an example of how it would be used.
Implementation
Just added a branch for the data telemetry. Since the server and add-ons can send arbitrary data, I added runtime validation to prevent sending bad data to telemetry.
Automated Tests
It's unfortunately not possible to test this because the client doesn't expose a way to fake an incoming notification. I did test it manually though.